Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora link returns 404 #2067

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fedora link returns 404 #2067

merged 1 commit into from
Jun 16, 2023

Conversation

calpeconsulting
Copy link
Contributor

Updated with correct path

Updated with correct path
@@ -24,7 +24,7 @@ body:
`sudo apt-get install jq`.

* jq 1.5 is in the official
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually at 1.6.4 now in Fedora 32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't released any revisions to 1.6- that -4 is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtlangford , since this seems to be a dead PR. I've confirmed here https://src.fedoraproject.org/rpms/jq/blob/master/f/sources that Fedora is using jq v1.6

Suggested change
* jq 1.5 is in the official
* jq 1.6 is in the official

Can you accept the GH suggestion and we get this closed, or would you prefer I make a new PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't released any revisions to 1.6- that -4 is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?

Apologies, I thought I had already done the update and you had to accept the PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought I had already done the update and you had to accept the PR?

@calpeconsulting The change in the PR still refers to jq 1.5. It needs to be jq 1.6.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.124% when pulling d9f63da on calpeconsulting:patch-1 into 5b9e63e on stedolan:master.

Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. This PR aims to fix the dead link, and versions can be fixed separately (we may drop mentioning versions each package managers).

@itchyny itchyny merged commit c2026f5 into jqlang:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants